JS: Migrate to new *Query.qll convention for files only to be imported by queries#6450
Merged
codeql-ci merged 10 commits intogithub:mainfrom Aug 17, 2021
Merged
Conversation
7be162d to
4cecd50
Compare
ef3d5be to
a6c3896
Compare
67a7c25 to
0047536
Compare
erik-krogh
approved these changes
Aug 16, 2021
Contributor
erik-krogh
left a comment
There was a problem hiding this comment.
I checked a few, and they looked fine.
I assume the rest are good as well.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adopts the convention that files defining a data-flow configuration should end with
Query.qll, and such files should only be imported from.qlfiles. The last part is already enforced by a PR check.To be consistent with other languages, these library files no longer wrap their contents in a module. So the new way to import the file is:
For backwards compatibility, the original file is still there, with a deprecated module alias pointing to the new file.